Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use codecov #2559

Merged
merged 4 commits into from
Oct 4, 2021
Merged

ci: use codecov #2559

merged 4 commits into from
Oct 4, 2021

Conversation

acud
Copy link
Member

@acud acud commented Oct 2, 2021 •
edited
Loading

This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@11f9aa8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2559   +/-   ##
=========================================
  Coverage          ?   63.83%           
=========================================
  Files             ?      232           
  Lines             ?    25734           
  Branches          ?        0           
=========================================
  Hits              ?    16428           
  Misses            ?     7823           
  Partials          ?     1483

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f9aa8...a7effa5. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@acud acud requested a review from vandot October 2, 2021 08:45
@acud acud self-assigned this Oct 2, 2021
@acud acud added the ready for review The PR is ready to be reviewed label Oct 4, 2021
mrekucci
mrekucci approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

vandot
vandot reviewed Oct 4, 2021
View reviewed changes
.github/workflows/go.yml
- name: Coveralls
- name: Test with race detector
if: matrix.os != 'ubuntu-latest'
run: make test-race
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acud you will also execute race-tests on Windows, I know that they were disabled for Windows, maybe its time to enable them again, don't know

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep i enabled them on purpose 👍

@acud acud merged commit 853737d into master Oct 4, 2021
@acud acud deleted the coveralls-to-odecov branch October 4, 2021 10:29
mrekucci pushed a commit that referenced this pull request Oct 5, 2021
@acud
ci: use codecov (#2559)
224e3d6
@acud acud added this to the v1.2.0 milestone Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandot vandot vandot left review comments

@mrekucci mrekucci mrekucci approved these changes

Assignees

@acud acud

Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acud @codecov-commenter @mrekucci @vandot