allow cors in dev mode #2866
Merged
allow cors in dev mode #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrekucci
approved these changes
Mar 31, 2022
notanatol
approved these changes
Mar 31, 2022
acud
approved these changes
Apr 13, 2022
|
commit linter is failing @significance. you'll need to adhere to conventional commits. please amend the commit message with |
significance
force-pushed
the
fix/cors-option-dev-mode
branch
from
777827c
to
6d15960
Compare
|
@acud did it 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
CORS mode was not enabled in dev mode and is needed in order to enable dapp developers to develop their app in a local development environment. Once it is merged I will add documentation.
Motivation and context (Optional)
Had to add this in order to develop https://swapchat.bzz.link
Related Issue (Optional)
None
Screenshots (if appropriate):
This change is