Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set default admin password in restricted dev #2947

Merged
merged 1 commit into from
May 17, 2022
Merged

feat: set default admin password in restricted dev #2947

merged 1 commit into from
May 17, 2022

Conversation

notanatol
Copy link
Contributor

@notanatol notanatol commented May 11, 2022 •
edited

Checklist

Description

To improve the developer's experience the dev mode has a default admin password when ran in restricted mode.

To be used like so:

POST localhost:1633/auth
Content-Type: application/json
Authorization: Basic OmhlbGxv

This change is Reviewable

@notanatol notanatol requested a review from agazso May 11, 2022 05:58
@agazso
Copy link
Member

agazso commented May 11, 2022

Looks good!

@notanatol notanatol requested review from acud and mrekucci May 11, 2022 14:45
@notanatol notanatol added the ready for review The PR is ready to be reviewed label May 12, 2022
@notanatol notanatol added this to the 1.6.0 milestone May 12, 2022
@mrekucci
Copy link
Contributor

Don't we want to bypass this in the dev mode instead of having a default password?

@notanatol
Copy link
Contributor Author

Don't we want to bypass this in the dev mode instead of having a default password?

my understanding is that the JS team want a default password value to make it easier to develop in dev mode.

@notanatol notanatol merged commit 6a8b694 into master May 17, 2022
@notanatol notanatol deleted the dev-default-password branch May 17, 2022 06:45
@istae istae modified the milestones: 1.6.0, 1.6.1 Jun 1, 2022
@AuHau
Copy link
Contributor

AuHau commented Jun 2, 2022

@notanatol is this documented somewhere?

@notanatol
Copy link
Contributor Author

@notanatol is this documented somewhere?

no, it's not.
I totally missed it, where would be a good place to put it?

@agazso
Copy link
Member

agazso commented Jun 2, 2022

As far as I know currently the dev mode is completely missing from the documentation.

Here is an issue about it, opened by @AuHau :)
ethersphere/bee-docs#240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agazso agazso agazso approved these changes

@acud acud acud approved these changes

@mrekucci mrekucci Awaiting requested review from mrekucci

Assignees
No one assigned
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@notanatol @agazso @mrekucci @AuHau @acud @istae