Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bmt): segment inclusion Merkle proofs #2952

Merged
merged 4 commits into from
May 18, 2022
Merged

feat(bmt): segment inclusion Merkle proofs #2952

merged 4 commits into from
May 18, 2022

Conversation

aloknerurkar
Copy link
Contributor

@aloknerurkar aloknerurkar commented May 12, 2022

Checklist

  • I have read the coding guide
  • My change requires a documentation update and I have done it
  • I have added tests to cover my changes.

Description

Motivation and context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):


This change is Reviewable

@aloknerurkar aloknerurkar marked this pull request as draft May 12, 2022 12:36
@aloknerurkar aloknerurkar marked this pull request as ready for review May 13, 2022 13:05
pkg/bmt/proof.go Show resolved Hide resolved
pkg/bmt/proof.go Show resolved Hide resolved
pkg/bmt/proof.go Show resolved Hide resolved
@acud acud added the ready for review The PR is ready to be reviewed label May 17, 2022
@aloknerurkar aloknerurkar requested a review from acud May 17, 2022 09:56
Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 When go 1.18 upgrade is merged, fuzzing here will be really nice.

@aloknerurkar aloknerurkar merged commit 93a0024 into master May 18, 2022
@aloknerurkar aloknerurkar deleted the SIP-BMT branch May 18, 2022 15:05
@istae istae added this to the 1.6.1 milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants