fix(kademlia): check if peer is blocklisted before connection #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
reviewed
May 23, 2022
pkg/topology/kademlia/kademlia.go
Outdated
| @@ -930,6 +930,10 @@ func (k *Kad) connect(ctx context.Context, peer swarm.Address, ma ma.Multiaddr) | |||
|
|
|||
| k.metrics.TotalOutboundConnectionAttempts.Inc() | |||
|
|
|||
| if blocklisted, _ := k.p2p.Blocklisted(peer); blocklisted { | |||
There was a problem hiding this comment.
@istae WDYT about having these checks directly inside the connectNeighbours and connectBalanced methods? this way we won't even pick the peer and try to connect to it, picking unsanctioned peers directly.
mrekucci
approved these changes
May 23, 2022
acud
reviewed
May 24, 2022
acud
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Motivation and context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
This change is