Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce logging during bootstrapping #2981

Merged
merged 2 commits into from
May 25, 2022
Merged

fix: reduce logging during bootstrapping #2981

merged 2 commits into from
May 25, 2022

Conversation

acud
Copy link
Member

@acud acud commented May 24, 2022 •
edited

Checklist

  • I have read the coding guide
  • My change requires a documentation update and I have done it
  • I have added tests to cover my changes.

Description

Motivation and context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

This change is Reviewable

@istae
Copy link
Member

istae commented May 24, 2022

Why can't we use logging.New(io.Discard, 0)

@acud
Copy link
Member Author

acud commented May 25, 2022

Why can't we use logging.New(io.Discard, 0)

good suggestion, thanks!

@acud acud merged commit 364bf92 into master May 25, 2022
@acud acud deleted the no-bootstrapper-log branch May 25, 2022 12:58
@istae istae added this to the 1.6.1 milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrekucci mrekucci mrekucci approved these changes

@notanatol notanatol notanatol approved these changes

Assignees
No one assigned
Labels
pull-request
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acud @istae @mrekucci @notanatol