fix: add sanity checks to ethereum gas prices #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notanatol
reviewed
Jul 6, 2022
pkg/transaction/transaction.go
Outdated
| } else { | ||
| gasPrice = request.GasPrice | ||
| } | ||
| if gasPrice.Cmp(minGasPrice) <= 0 { |
There was a problem hiding this comment.
would it make sense to have a check for a maximum gas price value?
There was a problem hiding this comment.
Not sure, we have a gas limit which is prefilled in most cases. @ralph-pichler what do you think?
There was a problem hiding this comment.
what a maximum sensible gas price is always depends on which network and which network conditions.
mrekucci
force-pushed
the
gas-price-sanity-check
branch
from
b91525b
to
38b7ed8
Compare
notanatol
approved these changes
Jul 6, 2022
ralph-pichler
approved these changes
Jul 6, 2022
acud
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Related Issue (Optional)
#3023; Closes #3020
This change is