Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resync the batchstore #3159

Merged
merged 13 commits into from
Aug 29, 2022
Merged

fix: resync the batchstore #3159

merged 13 commits into from
Aug 29, 2022

Conversation

notanatol
Copy link
Contributor

@notanatol notanatol commented Aug 9, 2022 •
edited
Loading

Checklist

  • I have read the coding guide
  • Add new snapshot feed, contract (maybe a test contract) address
  • update handshake version

Description

Closes: #3158

This change is Reviewable

@notanatol notanatol self-assigned this Aug 9, 2022
@notanatol notanatol changed the title fix: break fix: resync the batchstore Aug 9, 2022
@notanatol notanatol added the in progress ongoing development , hold out with review label Aug 9, 2022
@notanatol notanatol marked this pull request as draft August 9, 2022 09:20
@istae
Copy link
Member

istae commented Aug 15, 2022 •
edited
Loading

we can also use /pkg/statestore/leveldb/migration to nuke the batchstore during bootup, not sure if we need this separate versioning,

@notanatol notanatol added ready for review The PR is ready to be reviewed and removed in progress ongoing development , hold out with review labels Aug 22, 2022
@notanatol notanatol marked this pull request as ready for review August 24, 2022 11:51
@notanatol notanatol merged commit d472a3d into master Aug 29, 2022
@notanatol notanatol deleted the batchstore_v2f branch August 29, 2022 14:55
@aloknerurkar aloknerurkar added this to the 1.8.0 milestone Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldeffenb ldeffenb ldeffenb left review comments

@aloknerurkar aloknerurkar aloknerurkar approved these changes

@istae istae istae approved these changes

Assignees

@notanatol notanatol

Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Resync the batchstore from the events of the new contract
5 participants
@notanatol @istae @ldeffenb @aloknerurkar @metacertain