Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set stamp expiration to false if batch exists #3289

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Conversation

istae
Copy link
Member

@istae istae commented Sep 15, 2022

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • My change requires updating the Open API specification and/or changing its version, and I've done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

If the batchstore is unstable due to whatever reason, on reboot, if a batch exists, then the stamp should have field false regardless of previous value.

Motivation and context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):


This change is Reviewable

@istae istae added the ready for review The PR is ready to be reviewed label Sep 15, 2022
@istae istae requested review from a user and aloknerurkar and removed request for a user September 15, 2022 10:18
@istae istae merged commit 10f6acc into master Sep 15, 2022
@istae istae deleted the postage-expiration branch September 15, 2022 11:40
@aloknerurkar aloknerurkar added this to the 1.9.0 milestone Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants