perf(pushsync, retrieval): skiplist prunes items internally on expiration #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istae
changed the title
istae
changed the title
istae
requested review from
a team,
aloknerurkar and
notanatol
and removed request for
a team
| } | ||
|
|
||
| // An IntHeap is a min-heap of ints. | ||
| type timeHeap []int64 |
There was a problem hiding this comment.
This is a good candidate for introducing generics :)
mrekucci
reviewed
Apr 14, 2023
mrekucci
approved these changes
Apr 14, 2023
aloknerurkar
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
It was identified in a testing session that during uploads, most CPU cycles are wasted on pruning the skiplist.
With this change, the prune call is no longer needed before every push/retrieval.
The clean up call of items is done once at the time of expiration.
Internally, the skiplist now uses a minimum heap to wake up at the time of the closest expiration.
Before
After
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):