Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(depthmonitor): change threshold back to 50 percent #4013

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

istae
Copy link
Member

@istae istae commented Apr 17, 2023

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

as the reserve size gets near the tipping point of over filling and causing the radius to increase, it was discovered that the threshold of 40% is too low that fresh nodes may linger at a storage radius one higher than the rest of network.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

@istae istae marked this pull request as ready for review April 19, 2023 10:19
@istae istae requested review from a team, aloknerurkar and acha-bill and removed request for a team April 19, 2023 10:19
@istae istae merged commit 3142369 into master Apr 20, 2023
@istae istae deleted the depthmonitor-threshold branch April 20, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants