Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ask for a new libp2p password only once #4489

Merged
merged 4 commits into from
Dec 12, 2023
Merged

fix: ask for a new libp2p password only once #4489

merged 4 commits into from
Dec 12, 2023

Conversation

TobiaszCudnik
Copy link
Contributor

@TobiaszCudnik TobiaszCudnik commented Dec 1, 2023 •
edited

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Fixes #4262.

Currently, when starting a node with a default config, it asks for a new lib2p2 password each time, even when theres already one set.

Changes:

  • take the libp2p PK filename from 1 source for both writes and reads
  • make format

@mrekucci
Copy link
Contributor

@TobiaszCudnik please resolve the conflicts.

@notanatol notanatol changed the title fix: ask for a new lib2p2 password only once fix: ask for a new libp2p password only once Dec 12, 2023
@istae istae merged commit 5a867fe into ethersphere:master Dec 12, 2023
12 checks passed
@TobiaszCudnik TobiaszCudnik deleted the fix-create-a-new-lib2p2-password-only-once branch December 13, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janos janos janos approved these changes

@istae istae istae approved these changes

@notanatol notanatol notanatol approved these changes

@acha-bill acha-bill Awaiting requested review from acha-bill

@mrekucci mrekucci Awaiting requested review from mrekucci

Assignees
No one assigned
Labels
pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bee start falsely prints "Bee node is booting up for the first time. Please provide a new password."
5 participants
@TobiaszCudnik @mrekucci @janos @istae @notanatol