Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bee-js update #121

Merged
merged 19 commits into from
Jun 1, 2021
Merged

feat: bee-js update #121

merged 19 commits into from
Jun 1, 2021

Conversation

Cafe137
Copy link
Collaborator

@Cafe137 Cafe137 commented May 27, 2021 •
edited

  • Updates bee-js to 0.10.0
  • Updates bee to 0.6.2
  • Improves and shortens 404 error handling
  • Also adds nicer 500 handling to some places
  • Adds pinning reupload
  • Adds status
  • Renames checkoutOne to cashoutOne
  • Adds gasPrice and gasOption to cheque cashout
  • Adds a few more tests
  • Updates deposit and withdraw return types

@Cafe137 Cafe137 self-assigned this May 27, 2021
This was linked to issues May 27, 2021
Add reupload support (PATCH /bzz) #106
Closed
Error handling depends on HTTP response statusText #117
Closed
Failed to run command! #118
Closed
@Cafe137 Cafe137 mentioned this pull request May 27, 2021
Closed
@Cafe137 Cafe137 marked this pull request as ready for review May 27, 2021 21:32
@Cafe137 Cafe137 requested a review from nugaon as a code owner May 27, 2021 21:32
@Cafe137
Copy link
Collaborator Author

Cafe137 commented May 27, 2021

@AuHau How did you make the reupload tests pass in bee-js? 😅

@Cafe137 Cafe137 requested a review from agazso May 27, 2021 21:51
@AuHau
Copy link
Contributor

AuHau commented May 28, 2021

Heh, honestly I think I did not 😅 I thought with the latest PR I have figured out, but they are still very flaky :-( But your CI fails because of NPM not tests right?

nugaon
nugaon reviewed May 28, 2021
View reviewed changes
src/command/root-command/command-log.ts Outdated Show resolved Hide resolved
src/utils/types/index.ts Outdated Show resolved Hide resolved
src/utils/error.ts Outdated Show resolved Hide resolved
src/utils/error.ts Outdated Show resolved Hide resolved
Cafe137 and others added 2 commits May 31, 2021 12:05
refactor: improve namings and extract error printing options interface
5d8093a
@Cafe137
feat: status command (#125)
3888d72 
* feat: add status command

* refactor: remove version wrapper

* fix: fix status compatibility check

* feat: print supported bee version

* build: update to latest bee and bee-js

* build: set exact bee version
@Cafe137 Cafe137 requested a review from nugaon June 1, 2021 10:32
nugaon
nugaon approved these changes Jun 1, 2021
View reviewed changes
test/command/pinning.spec.ts Show resolved Hide resolved
@Cafe137 Cafe137 merged commit 9ff1827 into master Jun 1, 2021
@Cafe137 Cafe137 deleted the feat/bee-js-update branch June 1, 2021 11:59
@agazso agazso mentioned this pull request Jun 8, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nugaon nugaon nugaon approved these changes

@agazso agazso Awaiting requested review from agazso

Assignees

@Cafe137 Cafe137

Labels
pull-request
Projects
None yet
Milestone
No milestone
3 participants
@Cafe137 @AuHau @nugaon