network/retrieval: fix race condition where a retrieve request has be…

…en (#1902) answered before peer.addRetrieval was called Co-Authored-By: Ralph Pichler <pichler.ralph@gmail.com>
ethersphere · Oct 23, 2019 · e9042ba · e9042ba
1 parent 1a64457
commit e9042ba
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/network/retrieval/retrieve.go b/network/retrieval/retrieve.go
@@ -423,14 +423,13 @@ FINDPEER:
 		Addr: req.Addr,
 	}
 	protoPeer.logger.Trace("sending retrieve request", "ref", ret.Addr, "origin", localID, "ruid", ret.Ruid)
+	protoPeer.addRetrieval(ret.Ruid, ret.Addr)
 	err = protoPeer.Send(ctx, ret)
 	if err != nil {
 		protoPeer.logger.Error("error sending retrieve request to peer", "ruid", ret.Ruid, "err", err)
 		return nil, err
 	}
 
-	protoPeer.addRetrieval(ret.Ruid, ret.Addr)
-
 	spID := protoPeer.ID()
 	return &spID, nil
 }