Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Unify naming for issuer & beneficiary #1553

Closed
vojtechsimetka opened this issue Jul 11, 2019 · 1 comment
Closed

Unify naming for issuer & beneficiary #1553

vojtechsimetka opened this issue Jul 11, 2019 · 1 comment
Assignees
@santicomp2014 @Eknir
Labels
cleanup code completion, add comments and more incentives on hold

Comments

@vojtechsimetka
Copy link

In the smart contracts we are now using issuer to indicate the owner of the SWAP chequebook who is also issuing cheques and beneficiary as the recipient of the cheques and ultimately the payments.

However, in the go code we still sometimes use a different names like owner that are confusing.
@holisticode holisticode added the cleanup code completion, add comments and more label Jul 30, 2019
@santicomp2014 santicomp2014 mentioned this issue Sep 2, 2019
Closed
@santicomp2014
Copy link
Contributor

On hold until PR #1718 is merged.
A refactor on my side will be necessary to incorporate the changes made in that PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@santicomp2014 santicomp2014

@Eknir Eknir

Labels
cleanup code completion, add comments and more incentives on hold
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@holisticode @vojtechsimetka @santicomp2014 @Eknir