Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Saving cheques #1796

Closed
Eknir opened this issue Sep 23, 2019 · 1 comment · Fixed by #1797
Closed

Saving cheques #1796

Eknir opened this issue Sep 23, 2019 · 1 comment · Fixed by #1797

Comments

@Eknir
Copy link
Contributor

Eknir commented Sep 23, 2019

balanceKey, sentChequeKey and receivedChequeKey are the keys for looking up respectively the balance, sent cheques and received cheques from a peer. However, the peers might be peers on multiple Ethereum networks, hence the keys must be appended with a networkID value (just as in the usedChequebookAtNetworkKey)

Without fixing this issue, accounting and peer interacting will probably result in bugs if the node has been connected to the same peers on different networks.

@holisticode
Copy link
Contributor

Decisions as per 24th September:

  • One StateStore instance per bzz NetworkID
  • The StateStore has no prefix for the blockchain ID
  • It is assumed that when you start the node and provide the swap-backend-url (and thus to which the chequebook is being deployed to and the factory you are going to use), that this is the backend you are going to use for this node
  • In other words, the node stores the first provided blockchain ID. If you restart the node and provide a different swap-backend-url, this would result in an error (and not boot the node)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants