Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

docker: create new dockerfiles that are context aware #1463

Merged
merged 1 commit into from
Jun 13, 2019
Merged

docker: create new dockerfiles that are context aware #1463

merged 1 commit into from
Jun 13, 2019

Conversation

skylenet
Copy link
Contributor

@skylenet skylenet commented Jun 13, 2019 •
edited by bzzbot
Loading

Major changes:

  • COPY . /swarm which has the benefit that we can create an image based on the current code without having to specifying the git commit.
  • Generating only 2 images:
    • swarm: bare minimum currently with the swarm+geth binary
    • alltools: contains all tools that are generated

@skylenet skylenet requested a review from nonsense June 13, 2019 10:24
@bzzbot bzzbot marked this pull request as ready for review June 13, 2019 12:28
nonsense
nonsense approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@nonsense nonsense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bzzbot bzzbot merged commit 3243c7b into master Jun 13, 2019
@bzzbot bzzbot deleted the docker branch June 13, 2019 12:53
@bzzbot bzzbot added this to the 0.4.1 milestone Jun 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nonsense nonsense nonsense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skylenet @nonsense @bzzbot