This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
swarm-smoke: fix check max prox hosts for pull/push sync modes #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
force-pushed
the
sync-modes-smoke-tests
branch
3 times, most recently
from
6581cf1
to
79e6b86
Compare
nonsense
commented
Jul 17, 2019
| } | ||
|
|
||
| var isSynced bool | ||
| err = rpcClient.Call(&isSynced, "bzz_isPushSynced", tagname) |
There was a problem hiding this comment.
This API is still not merged to master, but since it is behind a feature flag, I think it is fine to get the tests part first.
nonsense
force-pushed
the
sync-modes-smoke-tests
branch
from
79e6b86
to
27e63d0
Compare
chadsr
added a commit
to chadsr/swarm
that referenced
this pull request
Sep 23, 2019
* 'master' of github.com:ethersphere/swarm: (54 commits) api, chunk, cmd, shed, storage: add support for pinning content (ethersphere#1509) docs/swarm-guide: cleanup (ethersphere#1620) travis: split jobs into different stages (ethersphere#1615) simulation: retry if we hit a collision on tcp/udp ports (ethersphere#1616) api, chunk: rename Tag.New to Tag.Create (ethersphere#1614) pss: instrumentation and refactor (ethersphere#1580) api, cmd, network: add --disable-auto-connect flag (ethersphere#1576) changelog: fix typo (ethersphere#1605) version: update to v0.4.4 unstable (ethersphere#1603) swarm: release v0.4.3 (ethersphere#1602) network/retrieve: add bzz-retrieve protocol (ethersphere#1589) PoC: Network simulation framework (ethersphere#1555) network: structured output for kademlia table (ethersphere#1586) client: add bzz client, update smoke tests (ethersphere#1582) swarm-smoke: fix check max prox hosts for pull/push sync modes (ethersphere#1578) cmd/swarm: allow using a network interface by name for nat purposes (ethersphere#1557) pss: disable TestForwardBasic (ethersphere#1544) api, network: count chunk deliveries per peer (ethersphere#1534) network/newstream: new stream! protocol base implementation (ethersphere#1500) swarm: fix bzz_info.port when using dynamic port allocation (ethersphere#1537) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding a flag to specify the kind of smoke test to test for with respect to syncing:
pullsync- make sure that all chunks are hosted at all max prox hosts - previously we had a more relaxed version, where we were checking only one of the max prox hosts (if there were multiple)pushsync- make sure that all chunks are found at at least one max prox host - we don't know which node received our chunk, and sent back a receipt, it can be any one of the max prox hosts if there are multipleboth- same as 1.It also adds a flag to specify if we want to wait for
pushsyncorpullsyncto complete. Uploads attach atag, so that we can monitor thepushsyncuntil completion.