This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
storage: fix possible hasherstore deadlock on waitC channel #1674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a propsed solution for fixing a possible deadlock on hasherstore. It is possible that multiple errors are sent to the waitC channel, but that channel is red only once. This is causing deadlocks on:
and
goroutines.txt.gz
This change makes only possible to have one send to the waitC. But could it maybe create logical problems that I do not see? Please, review.