Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

swap: fix TestHandshake and TestEmitCheque #1721

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

holisticode
Copy link
Contributor

This PR fixes an inconsistency of TestHandshake.

It also fixes an issue left open in TestEmitCheque.

Closes #1711

@holisticode
Copy link
Contributor Author

Also closes #1642

@holisticode holisticode force-pushed the incentives-revisit-testhandshake branch from e067e32 to a166aa8 Compare September 2, 2019 21:40
Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@holisticode holisticode merged commit f8e4dc6 into master Sep 4, 2019
kortatu pushed a commit to epiclabs-io/swarm that referenced this pull request Sep 6, 2019
@skylenet skylenet added this to the 0.5.0 milestone Sep 17, 2019
chadsr added a commit to chadsr/swarm that referenced this pull request Sep 23, 2019
* 'master' of github.com:ethersphere/swarm:
  swap: fix TestHandshake and TestEmitCheque (ethersphere#1721)
  cmd/swarm-smoke: prevent smoke test from executing trackChunks twice when we debug (ethersphere#1717)
  swap, contracts, vendor: move to waiver-free simplestswap (ethersphere#1683)
@mortelli mortelli deleted the incentives-revisit-testhandshake branch November 14, 2019 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revisit TestHandshake
4 participants