This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
bzzeth: protocol runloop now quits on peer disconnect #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janos
reviewed
Sep 11, 2019
janos
reviewed
Sep 11, 2019
bzzeth/bzzeth_test.go
Outdated
| // Wait for sometime and see if peer is connected and idling | ||
| time.Sleep(1000 * time.Millisecond) | ||
| if _, ok := b.peers.peers[node.ID()]; !ok { | ||
| t.Fatalf("peer is not connected") |
There was a problem hiding this comment.
This test seems flaky now:
ERROR[09-11|15:53:03.329|github.com/ethersphere/swarm/p2p/protocols/protocol.go:238] peer.handleIncoming err="Message handler error: (msg code 1): received message from Swarm node"
--- FAIL: TestBzzBzzHandshake (1.09s)
bzzeth_test.go:162: peer still connected
FAIL
coverage: 46.0% of statements
FAIL github.com/ethersphere/swarm/bzzeth 2.364s
There was a problem hiding this comment.
I added some delay after sending the dummy message... It should work fine now.
There was a problem hiding this comment.
I know that we are trying to avoid adding sleeps to tests. I it possible to fix flakiness with other methods?
BTW, I do not see the new delay, did you push?
There was a problem hiding this comment.
Sleep seems to be the option for now...
There was a problem hiding this comment.
I would like to hear other opinions on using sleeps.
zelig
suggested changes
Sep 12, 2019
zelig
suggested changes
Sep 13, 2019
janos
reviewed
Sep 13, 2019
janos
approved these changes
Sep 13, 2019
janos
reviewed
Sep 13, 2019
janos
suggested changes
Sep 13, 2019
zelig
approved these changes
Sep 14, 2019
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| if _, ok := b.peers.peers[node.ID()]; ok { | ||
| t.Fatalf("peer still connected") | ||
| // after successful handshake, expect peer added to peer pool |
There was a problem hiding this comment.
there is a disconnected call on the tester.
| t.Fatalf("peer is not connected") | ||
| // after successful handshake, expect peer added to peer pool | ||
| var p *Peer | ||
| for i := 0; i < 10; i++ { |
|
|
||
| func isPeerDisconnected(id enode.ID, b *BzzEth) (p *Peer) { |
There was a problem hiding this comment.
imprecise, this is testing if peer is not in testpool
zelig
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1730