This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 112
travis: remove go1.12 job #1784
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/ethersphere/swarm | ||
|
|
||
| go 1.12 | ||
| go 1.13 | ||
|
|
||
| require ( | ||
| bazil.org/fuse v0.0.0-20160811212531-371fbbdaa898 | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go 1.12 is not needed for PPA, but it is a supported Go version. Last two releases are. Maybe we should keep it for this reason and change the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to support go1.12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that we supported current and previous go version. I could be wrong. If we are supporting only the current, then the job is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously we were supporting 1.11 and 1.12 mainly because the Ubuntu PPA needs 1.11.
IMO we can remove 1.12 because none of our build systems need it. Our binaries are published using 1.13.
I'm also in favor of getting rid of 1.11 and the Ubuntu PPA builds, but that's a topic for the roundtable :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe our codebase does not need to ensure support for previous go version for people that cannot upgrade right away, as it is easy to have two version one beside another. In that case, removing this job is ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i also thought it was deliberate check for backward compatibility one version back. I would leave it. is it really making CI faster given parallelism?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backward compatibility is not needed IMO. Our binaries are released with go1.13, so why should we care about supporting go1.12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this is an open source project, someone may still use older but still supported Go version to build or use some of the packages from swarm. Maybe we still did not reach that level of project maturity or popularity, so ensuring that project works only with the latest release is just fine, and that we can think about this later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment on the CI from my side - we have 5 concurrent jobs in total for the
ethersphereorganisation, so if half of them are used on jobs we don't need, CI is essentially twice slower, specially when you have to wait for free executors - yesterday we waited for one-two hours to get helm charts released, due to many PRs being submitted at the same time.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we still did not reach that level of project maturity or popularity, so ensuring that project works only with the latest release is just fine, and that we can think about this later.- exactly my opinion on this PR.