This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
api, cmd: add pinning feature flag #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
moved this from Backlog
to In review (includes Documentation)
in Swarm Core - Sprint planning
|
LGTM, but there are no tests. Considering the timeframe we are under, I can understand that, but have you tried it locally? |
nonsense
approved these changes
Sep 23, 2019
of course. |
janos
reviewed
Sep 23, 2019
api/http/server.go
Outdated
| @@ -106,7 +106,6 @@ func NewServer(api *api.API, pinAPI *pin.API, corsString string) *Server { | |||
| server := &Server{api: api, pinAPI: pinAPI} | |||
|
|
|||
| defaultMiddlewares := []Adapter{ | |||
| RecoverPanic, | |||
There was a problem hiding this comment.
We do not need RecoverPanic adapter?
There was a problem hiding this comment.
I'm inclined to remove it at this point. I think we should not catch panics as it might eclipse bugs and create possible database inconsistencies.
WDYT @janos?
Swarm Core - Sprint planning
automation
moved this from In review (includes Documentation)
to Done
Sep 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature flag to enable/disable pinning on a node.
Nodes would now be started with pinning disabled on default in order to simplify deployment configuration for those running gateways (in order to prevent external users pinning content through gateways, therefore possibly overloading gateway storage and bandwidth).
Users that would like to use this feature should bring their nodes up with
--enable-pinningflag.fixes #1732