This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
swap: return the balance in swap.Balance for an unconnected but prior peer #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralph-pichler
force-pushed
the
swap_balance_unconnected_peer
branch
from
7c9b3d6
to
24b3fd2
Compare
holisticode
approved these changes
Sep 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
swap_Balancecall to return the last balance of a currently disconnected (but previously connected to) peer instead of a not found error. This behaviour was accidentally changed during the peer refactoring PR. A test for this was also added.