This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
cmd/swarm: fix progress bars for encrypted uploads #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
changed the title
acud
changed the title
nonsense
approved these changes
Oct 3, 2019
nonsense
reviewed
Oct 3, 2019
cmd/swarm/upload.go
Outdated
| oldTag := *tag | ||
| lastTime := time.Now() | ||
|
|
||
| for { | ||
| time.Sleep(pollDelay) | ||
| newTag, err := client.TagByHash(tag.Address.String()) | ||
| newTag, err := client.TagByHash(hash) | ||
| if err != nil { | ||
| utils.Fatalf("had an error polling the tag for address %s, err %v", tag.Address.String(), err) |
There was a problem hiding this comment.
Should be hash, instead of tag.Address.String()
There was a problem hiding this comment.
that's exactly what it is... not sure if i follow....
There was a problem hiding this comment.
If tag.Address.String() was the same as hash, this change would not be needed. I am talking about line 219 (old) line 221 (new), already pushed the change.
skylenet
approved these changes
Oct 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes progress bars for encrypted uploads