This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
swap: improve balance tests #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor swap tests cheques
…tire TestCheques function
…p-improve-balance-tests # Conflicts: # swap/swap_test.go
mortelli
added
in progress
and removed
builds on open PR
…e-tests # Conflicts: # swap/protocol.go # swap/swap.go # swap/swap_test.go
Eknir
reviewed
Nov 4, 2019
| // create a test swap account | ||
| swap, clean := newTestSwap(t, ownerKey, nil) | ||
| defer clean() | ||
| // test previous results are still correct |
There was a problem hiding this comment.
What is the added value of these extra tests?
There was a problem hiding this comment.
the value isn't huge (in fact, it's an arguably somewhat paranoic practice) but since we progressively deal with different peers, it's conceivable that after working with a new one, results from the previous peer could be affected (and therefore, be erroneous).
one could apply this logic for many more cases, though
Eknir
approved these changes
Nov 4, 2019
There was a problem hiding this comment.
Functionally not much changed, but a good cleanup. Thanks for doing this!
In both TestBalance and TestBalances, you add extra test cases in the end, seemingly testing something which you already tested before. I am curious why you would do this.
Looks good to me!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to improve the test functions for the peer balances RPCs, in terms of code clarity, tidiness and test cases coverage.
Test+name of the function they are testingheuristic.