This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
pushsync: split sync to chunksWorker and receiptsWorker #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
reviewed
Oct 23, 2019
pushsync/pusher_test.go
Outdated
| if !delayResponse() { | ||
| return nil | ||
| } | ||
| // if !delayResponse() { |
acud
reviewed
Oct 23, 2019
pushsync/pusher.go
Outdated
| } | ||
| // finish span for pushsync roundtrip, only have this span if we have a tag | ||
| item.span.Finish() | ||
| //go func(ch chunk.Chunk) { |
acud
reviewed
Oct 23, 2019
nonsense
approved these changes
Oct 23, 2019
|
Great stuff, thanks, Janos. Once this gets merged, we should benchmark |
|
Thank you, Anton. This is a joint effort. :) |
nonsense
approved these changes
Oct 23, 2019
acud
approved these changes
Oct 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are cherry picked changes on pusher from obsolete PR #1857.