This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
netkwork/hive: addPeer function assigned after launching goroutine co… #1896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At hive Start() we launch the loadPeers and inside it we launch the goroutine
go h.connectInitialPeers(conns)
. After that addPeer is assigned, this resulted that in some test executions, the connection to the peers is done before the function is set.We have moved the assign before the loadPeers call.
Previous error