This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two data races found in PSS. Both are related to production code, not only test code.
One is related to Ticker.quitC being set on Stop while waiting on the same channel in a different goroutine which can cause reading from the nil channel which blocks forever resulting in infinite ticker and goroutine leak.
Another data race is on mutating and reading capabilities from topicHandlerCaps which can result in incorrect raw or prox states in handlePssMsg. The original logic in PSS.Register should be preserved.
The acceptance criteria is that
go test -count 1 ./pss -race
passes successfully.