Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

network/retrieval: fix request race #1902

Merged
merged 1 commit into from
Oct 23, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions network/retrieval/retrieve.go
Original file line number Diff line number Diff line change
Expand Up @@ -423,14 +423,13 @@ FINDPEER:
Addr: req.Addr,
}
protoPeer.logger.Trace("sending retrieve request", "ref", ret.Addr, "origin", localID, "ruid", ret.Ruid)
protoPeer.addRetrieval(ret.Ruid, ret.Addr)
err = protoPeer.Send(ctx, ret)
if err != nil {
protoPeer.logger.Error("error sending retrieve request to peer", "ruid", ret.Ruid, "err", err)
return nil, err
}

protoPeer.addRetrieval(ret.Ruid, ret.Addr)

spID := protoPeer.ID()
return &spID, nil
}
Expand Down