This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
storage/localstore: do not later batch in setSync if moveToGc is false #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
approved these changes
Oct 28, 2019
acud
moved this from In progress
to In review (includes Documentation)
in Swarm Core - Sprint planning
nonsense
approved these changes
Oct 28, 2019
Swarm Core - Sprint planning
automation
moved this from In review (includes Documentation)
to Done
Oct 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with localstore setSync altering batch when moveToGc is set to false. The batch set in this case is not complete in order to changed access time and gc size change. The result of such mistake is incorrect gc size tracking.
@nonsense This can be validated by running smoke tests and checking bzz_storageIndices rpc response.