This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
chunk: fix tag Sent value on load, dont persist done tags #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
moved this from Backlog
to In review (includes Documentation)
in Swarm Core - Sprint planning
janos
reviewed
Oct 29, 2019
|
|
||
| // prevent a condition where a chunk was sent before shutdown | ||
| // and the node was turned off before the receipt was received | ||
| v.Sent = v.Synced |
There was a problem hiding this comment.
I wonder if there would be similar data inconsistencies that we could not notice, which would result in strange behaviour. This is a sign that persistence is not reliable.
janos
approved these changes
Oct 29, 2019
zelig
approved these changes
Nov 1, 2019
Swarm Core - Sprint planning
automation
moved this from In review (includes Documentation)
to Done
Nov 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a state where a chunk was sent with push sync but for which a receipt was not received due to node shutdown. Thus, it is mandatory to set the
tag.Sentcounter to thetag.Syncedcounter, so that the next send of the same chunk (which still exists in push sync index) is accounted for correctly.Another change introduced here is that
Donetags should not be persisted. I am open to discuss this but it seemed like the right thing to do at the lack of some sort of pruning mechanism. I am considering either this approach or an approach where only tags which are done and older thanXdays should not be persisted across sessions. Inputs would be appreciated.