This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
cmd/swarm: swap --sync-mode flag with --no-sync flag #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests TestConfigCmdLineOverrides and TestConfigCmdLineOverridesFile are failing. |
acud
force-pushed
the
remove-syncmode-flag
branch
from
74d1311
to
9d991bb
Compare
acud
added
cleanup
acud
moved this from In progress
to In review (includes Documentation)
in Swarm Core - Sprint planning
janos
approved these changes
Nov 14, 2019
nolash
approved these changes
Nov 14, 2019
acud
force-pushed
the
remove-syncmode-flag
branch
from
9d991bb
to
43bbaf2
Compare
Swarm Core - Sprint planning
automation
moved this from In review (includes Documentation)
to Done
Nov 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
--sync-modeflag to be--no-syncflag in order to still preserve the functionality of disabling syncing altogether, while adhering to the open task list on #1926