This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
localstore: fix subscribe push iterator tag value #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
moved this from Backlog
to In review (includes Documentation)
in Swarm Core - Sprint planning
|
piggybacked a small change to set |
janos
approved these changes
Nov 25, 2019
zelig
approved these changes
Nov 26, 2019
Swarm Core - Sprint planning
automation
moved this from In review (includes Documentation)
to Done
Nov 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the value of the tag we set on the push index value. This was previously taken from the
retrievalDataIndexitem which does not contain the tag at all so a tag with value0would always be set in the push sync index.The PR also adds an
elseblock insetSyncto prevent a panic on a nil pointer when the tag isnil(when an error is received fromlocalstore.tags).discovered by @janos <3