This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
network/retrieval: integrate kademlia load balancing #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
force-pushed
the
retrieval-klb
branch
2 times, most recently
from
c5677bb
to
c8d8b00
Compare
acud
moved this from In progress
to In review (includes Documentation)
in Swarm Core - Sprint planning
janos
reviewed
Nov 27, 2019
janos
approved these changes
Nov 28, 2019
with load balancing; remove unnecessary logging, add TestEachBinOffPeers
pradovic
approved these changes
Jan 6, 2020
Swarm Core - Sprint planning
automation
moved this from In review (includes Documentation)
to Done
Jan 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the Kademlia Load Balancer component into the
retrievalprotocol. Apart from getting rid of theTracelog-lines which are not very meaningful at this point it does not seek to simplify thefindPeerlogic. The old method is left as is (without the loglines) for reference and comparison. Simplification of thefindPeerLBshould come as a subsequent iteration.Also, a unit test for the load balancer that checks that
Offpeers don't get iterated over was added (this case was not originally implemented).When reviewing please compare
findPeerandfindPeerLBside by side. Since the mechanics of the iterators are a bit different some changes had to be made on how peers are iterated over.