This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
storage/netstore: optimize fetchers for faster forwarding #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
force-pushed
the
fetcher-faster-forward
branch
2 times, most recently
from
fe92a6b
to
12a7ed0
Compare
acud
moved this from Backlog
to In review (includes Documentation)
in Swarm Core - Sprint planning
acud
force-pushed
the
fetcher-faster-forward
branch
from
12a7ed0
to
fcd4eee
Compare
acud
force-pushed
the
fetcher-faster-forward
branch
2 times, most recently
from
775f0bf
to
3a3ba3d
Compare
acud
force-pushed
the
fetcher-faster-forward
branch
from
3a3ba3d
to
003e1ce
Compare
|
Smoke tests are passing on this branch https://snapshot.raintank.io/dashboard/snapshot/6TJcQ0gERiQSPyEjrvqbreJqmNCPPWWc and show a bit higher average download speed (5.253 MBs) then it was on 0.5.3 release #1974 (comment) (3.25 MBs). |
|
Smoke tests are running stable for one day, with average download speed 5.088 MB/s https://snapshot.raintank.io/dashboard/snapshot/rkqGTaAMStPFQYrxBI6RM2rfUte8vjC1. |
janos
approved these changes
Dec 3, 2019
zelig
approved these changes
Dec 3, 2019
Swarm Core - Sprint planning
automation
moved this from In review (includes Documentation)
to Done
Dec 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to optimize fetchers for faster forwarding of chunks.
The main problem with the current implementation on
masteris that a delivery of a fetcher is notified to the goroutines blocking on the delivery only after the chunk has been put to the localstore (by the means of closing theDeliveredchannel on the fetcher). This is an obvious forfeit on performance.The proposed solution is to add a
Chunkfield on theFetcherstruct. This field will be safely set whenonce.Do()is called upon chunk delivery. The goroutines blocking on the delivery will then unblock and read the data from theChunkfield. This skips the localstorePutandGetwhen delivering the chunks.