This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
log, network, storage, testutil: Log base address only in tests #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradovic
changed the title
pradovic
changed the title
pradovic
force-pushed
the
logs-base-test
branch
from
aacd0c7
to
83de16f
Compare
janos
approved these changes
Dec 4, 2019
| // Export go-ethereum/log interface so that swarm/log can be used with it interchangeably | ||
| type Logger = l.Logger | ||
|
|
||
| func NewBaseAddressLogger(baseAddr string, ctx ...interface{}) l.Logger { |
zelig
approved these changes
Dec 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging of base address is useful in tests and not so much in the production. This is one way of implementing this functionality without big changes to the code base.
The base address logging is enabled in
testutil/init, however we could also do it with the init fuction of a separate test file, flagtestutil, or custom build tags if it is more preferable.