This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
storage: Preserve counter across Encrypt() calls #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janos
reviewed
Dec 4, 2019
janos
approved these changes
Dec 4, 2019
|
@janos sorry I forgot to add the |
janos
approved these changes
Dec 4, 2019
pradovic
approved these changes
Dec 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current code state, the counter is reset on every call to
Encrypt(). This means that the result of data will depend on how it is buffered. To persist the counter acrossEncrypt()calls increases flexibility.