This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
cmd, metrics: decouple metrics and cli library #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradovic
approved these changes
Dec 20, 2019
pradovic
approved these changes
Dec 20, 2019
holisticode
approved these changes
Dec 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples cli library from swarm metrics. Metrics defines and uses cli flags for configuration making it highly coupled to the main package with hard requirement on the specific cli library. This change removes that coupling allowing switching to a different cli library in the main package.
Packages swarm-smoke and swarm-smoke-pss use only flags from the metrics package, not any other code. I have duplicated these flags as all swarm smoke packages would have to be reviewed soon and improved.
This PR is a preparation for using cobra/viper in swarm main package.