This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
swarm: simplify network test #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
force-pushed
the
simplify-network-test
branch
2 times, most recently
from
9e44b96
to
8dc71a6
Compare
janos
suggested changes
Jan 8, 2020
acud
force-pushed
the
simplify-network-test
branch
from
8dc71a6
to
c55dd9a
Compare
acud
force-pushed
the
simplify-network-test
branch
from
36f9c79
to
7ec1d31
Compare
acud
moved this from In progress
to In review (includes Documentation)
in Swarm Core - Sprint planning
janos
approved these changes
Jan 10, 2020
| syncing = false | ||
| for _, id := range nodeIDs { | ||
| if sim.MustNodeItem(id, bucketKeyInspector).(*api.Inspector).IsPullSyncing() { | ||
| syncing = true |
There was a problem hiding this comment.
I think that after syncing = true a break can go.
There was a problem hiding this comment.
true. i missed this at first view. will piggy back this over some other PR 👍
pradovic
approved these changes
Jan 10, 2020
zelig
approved these changes
Jan 11, 2020
Swarm Core - Sprint planning
automation
moved this from In review (includes Documentation)
to Done
Jan 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify the network test file because some of the tests are flaking.
The structure, concurrency and counter pointers that are passed around make it very difficult to debug and understand.