big update to modern package versions, many changes to tests + more #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwithoos
requested review from
EthicalJobsJesse,
nasimoyz and
VeryStrongFingers
EthicalJobsJesse
approved these changes
Mar 29, 2021
| * @return $this | ||
| */ | ||
| public function push($criteria) | ||
| public function push(...$values) |
There was a problem hiding this comment.
ive never seen ... syntax in php, does it bundle all the args into a single value?
There was a problem hiding this comment.
it's the "splat" operator used for argument unpacking https://wiki.php.net/rfc/argument_unpacking
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| php: [ 7.3 ] | ||
|
|
||
| name: PHPUnit (PHP ${{ matrix.php }}) | ||
| name: PHPUnit (PHP 7.3) | ||
|
|
There was a problem hiding this comment.
FYI this could have been used to run the tests on various PHP versions (eg. 7.4 & 8.0)
There was a problem hiding this comment.
oh hmmm... yeah forward-support's a nice idea. I'll add it, see if it passes out of the box, if so I'll keep otherwise I'll leave as-is
VeryStrongFingers
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be tagged as a new major version.