Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add EOSE class to obtain subscriptionId #41

Merged
merged 3 commits into from
Dec 11, 2023
Merged

feat: add EOSE class to obtain subscriptionId #41

merged 3 commits into from
Dec 11, 2023

Conversation

uchijo
Copy link
Contributor

@uchijo uchijo commented Dec 6, 2023

Hi, maybe I should've open an issue first, but I got this implementation, so I thought it'd be fast if you check the code directory.

what I added

added class that represent EOSE mesasge.
it only has subscription field.

motivation

Currently, there is no subscriptionId field in the Message of dart-nostr, nor is there any class representating eose.
in the case there are several subscriptions on one relay, we may want to distinguish which subscription is the received eose related to.
to achieve this, we need to know eose's subscription id.

ethicnology
ethicnology approved these changes Dec 11, 2023
View reviewed changes
Copy link
Owner

@ethicnology ethicnology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ethicnology ethicnology changed the title add eose object to obtain subscriptionId, when the received message is "EOSE" refactor: add eose object to obtain subscriptionId, when the received message is "EOSE" Dec 11, 2023
@ethicnology ethicnology changed the title refactor: add eose object to obtain subscriptionId, when the received message is "EOSE" feat: add eose object to obtain subscriptionId, when the received message is "EOSE" Dec 11, 2023
@ethicnology ethicnology changed the title feat: add eose object to obtain subscriptionId, when the received message is "EOSE" feat: add EOSE class to obtain subscriptionId Dec 11, 2023
@ethicnology ethicnology merged commit 29d80f5 into ethicnology:develop Dec 11, 2023
@ethicnology ethicnology mentioned this pull request Dec 11, 2023
Merged
ethicnology added a commit that referenced this pull request Dec 11, 2023
@ethicnology @uchijo
v1.5.0 (#42)
6c9a630 
* feat: add EOSE class to obtain subscriptionId (#41)

* added EOSE class

* added tests

* Message.deserialize handle EOSE

* chore: bump version

---------

Co-authored-by: Yuta Uchijo <70194083+uchijo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethicnology ethicnology ethicnology approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uchijo @ethicnology