don't pass empty newMethodCallback function to ethjs-query call
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change to ethjs-query ethjs/ethjs-query@dd1d1b2 will not return a promise if any callback function is passed. This breaks promise returns for `.new()`, since this was always passing a function through to the ethjs-query `sendTransaction` call. With this commit, the callback function will only be passed to `sendTransaction` if a callback was defined.
|
Thanks! Will review today.
…Sent from my iPhone
On Apr 9, 2018, at 4:39 AM, Coveralls ***@***.***> wrote:
Coverage remained the same at 100.0% when pulling 71a6b29 on mikec:fix-promises into 7a75bfc on ethjs:master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Will review tomorrow.
…Sent from my iPhone
On Apr 9, 2018, at 4:39 AM, Coveralls ***@***.***> wrote:
Coverage remained the same at 100.0% when pulling 71a6b29 on mikec:fix-promises into 7a75bfc on ethjs:master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
This and other things have been addressed in 2.0 @mikec thanks for the PR regardless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to ethjs-query ethjs/ethjs-query@dd1d1b2 will not return a promise if any callback function is passed. This breaks promise returns for
.new(), since this was always passing a function through to the ethjs-querysendTransactioncall. With this commit, the callback function will only be passed tosendTransactionif a callback was defined.ethjs-contract
Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.
Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.
Before opening a pull request, please ensure:
Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)
IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.