Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promise to callback #6

Merged
merged 2 commits into from Apr 30, 2018
Merged

Promise to callback #6

merged 2 commits into from Apr 30, 2018

Conversation

kumavis
Copy link
Contributor

@kumavis kumavis commented Apr 28, 2018 •
edited

Fixes #5
only added "promise-to-callback": "^1.0.0" to deps but npm automatically sorted the devDeps

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 104c438 on kumavis:promise-to-callback into 30f7839 on ethjs:master.

@SilentCicero
Copy link
Member

Okay will review, @kumavis thanks again.

@SilentCicero SilentCicero merged commit a6fe31f into ethjs:master Apr 30, 2018
@kumavis kumavis deleted the promise-to-callback branch April 30, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kumavis @coveralls @SilentCicero