-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Java Modules #14
Comments
This was referenced Apr 27, 2023
Hi! Thanks for your request. |
Yes, exactly. Both conditions are required. Here's how the PR could look like networknt/json-schema-validator#728 Btw, I could also prepare a GH workfklow for build/test. |
Yes, both options sounds like an improvement to me, thank you! |
aalmiray
added a commit
to aalmiray/itu
that referenced
this issue
Apr 28, 2023
ethlo
pushed a commit
that referenced
this issue
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
v1.7.2
defines an automatic module nameI'd be great if the library supplied a full Java module descriptor. It's possible to keep bytecode baseline compatible with Java 8 while providing a full module descriptor thanks to ModiTect. This will help modular projects that consume this library, specifically those that create custom Java Runtimes with
jlink
, as the latter does not support automatic modules but explicit modules. If interested I can send a PR to make it happen.The text was updated successfully, but these errors were encountered: