Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotti "Görli Classic" Testnet Support #17

Merged
merged 7 commits into from
Jan 23, 2019
Merged

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Jan 2, 2019

Kotti, cross-client proof-of-authority testnet for Ethereum Classic.

As per https://github.com/goerli/testnet

  • Name: Kotti
  • Machine-readable name: --kotti
  • Stage: launched
    • PoA Engine: clique
    • Epoch interval: 30000
    • Step period: 15
    • Genesis hash: 0x14c2283285a88fe5fce9bf5c573ab03d6616695d717b12a127188bcacfc743c4
    • Network ID: 6
    • Chain ID: 6
    • Homestead: 0,
    • EIP150: 0,
    • EIP155: 0,
    • Disposal: 0,
    • ECIP1017EraRounds: 5000000,
    • EIP160: 0,
    • ECIP1010Pause: 0,
    • ECIP1010Length: 2000000,
  • Gitter: https://gitter.im/goerli/kotti/

…) (#6)

Makes Interface interface a bit more stateless and abstract.

Obviously this change is dictated by EVMC design. The EVMC tries to keep the responsibility for EVM features totally inside the VMs, if feasible. This makes VM "stateless" because VM does not need to pass any information between executions, all information is included in parameters of the execute function.
@5chdn 5chdn changed the title [WIP] Kotti "Görli Classic" Testnet Support Kotti "Görli Classic" Testnet Support Jan 23, 2019
@5chdn
Copy link
Contributor Author

5chdn commented Jan 23, 2019

Ok this is ready to be reviewed and tested

make geth && build/bin/geth --kotti

should match: https://github.com/goerli/testnet/blob/master/geth/kotti.genesis

@@ -212,9 +212,9 @@ None
#### Result
- array with account records:
- account.address [string]: account address that is derived from the generated key
- account.type [string]: type of the
- account.type [string]: type of the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, typo. Should be type of the account.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(fine to leave as-is)

@sorpaas
Copy link
Collaborator

sorpaas commented Jan 23, 2019

nitpick (but fine to leave it like it is): with Disposal being 0, ECIP1010 parameters are not used at all.

@sorpaas sorpaas merged commit 0605a5b into multi-geth:master Jan 23, 2019
@5chdn 5chdn deleted the multi-geth branch January 23, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants