Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lodestar image is missing commit hash #120

Closed
nflaig opened this issue Jan 11, 2024 · 2 comments · Fixed by #122
Closed

Lodestar image is missing commit hash #120

nflaig opened this issue Jan 11, 2024 · 2 comments · Fixed by #122

Comments

@nflaig
Copy link

nflaig commented Jan 11, 2024

As noted by @marioevz in ChainSafe/lodestar#6276 (Additional context) it looks like the Lodestar image unstable-linux-amd64 does not include the commit hash in version info. This makes it difficult to determine the exact version (code) that is running based on the logs.

Based on the workflows of this repo it looks like it uses the Dockerfile from the Lodestar repo to build the image but does not pass the COMMIT build arg which is required to write git data.

For reference, this is how we pass the commit hash in our build step

--build-arg COMMIT=$(git rev-parse HEAD)
@skylenet
Copy link
Member

Should be good now for any future built images. Thanks for creating the issue and mentioning which env var should be passed during build time 🙏

@nflaig
Copy link
Author

nflaig commented Jan 12, 2024

Awesome, thanks for the fast fix!

I can confirm that the commit hash is included in the version now

~> docker run ethpandaops/lodestar:unstable --help
🌟 Lodestar: TypeScript Implementation of the Ethereum Consensus Beacon Chain.

 * Version: v1.13.0/aa87c54
  * by ChainSafe Systems, 2018-2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants