Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Participant parsing is broken #227

Closed
parithosh opened this issue Sep 25, 2023 · 1 comment · Fixed by kurtosis-tech/eth-network-package#133
Closed

Participant parsing is broken #227

parithosh opened this issue Sep 25, 2023 · 1 comment · Fixed by kurtosis-tech/eth-network-package#133

Comments

@parithosh
Copy link
Member 

    {
      "el_client_type": "geth",
      "el_client_image": "ethpandaops/geth:lightclient-devnet-8-edf4ab3",
      "cl_client_type": "lighthouse",
      "cl_client_image": "sigp/lighthouse:deneb",
      "count": 3
    },

with "mev_type": "mock", leads to the following args passed to lighthouse:

"--builder=http://mev-boost-0:18550", "--builder=http://mev-boost-1:18550", "--builder=http://mev-boost-2:18550"

while just one of those needs to be passed to each participant.
@leoporoli leoporoli mentioned this issue Sep 25, 2023
Merged
h4ck3rk3y pushed a commit to kurtosis-tech/eth-network-package that referenced this issue Sep 26, 2023
@leoporoli
fix: deep copy participant before adding it into the participants list (
8380599 
#133)

participants list had elements that were sharing mutable lists, now, it
creates a new object for each new participant on the list with this
change.

It's related to this issue:
bazelbuild/starlark#192 (comment)

it's should fix:
ethpandaops/ethereum-package#227
@leoporoli
Copy link
Contributor

leoporoli commented Sep 26, 2023 •
edited
Loading

Fixed here: kurtosis-tech/eth-network-package#134 and here: kurtosis-tech/eth-network-package#133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@parithosh @leoporoli