Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Ethereum Kurtosis package to disable peer scoring #304

Closed
bsamuels453 opened this issue Oct 18, 2023 · 4 comments · Fixed by #311 or #307
Closed

Update the Ethereum Kurtosis package to disable peer scoring #304

bsamuels453 opened this issue Oct 18, 2023 · 4 comments · Fixed by #311 or #307

Comments

@bsamuels453
Copy link
Contributor

cc @barnabasbusa

crytic/attacknet#6

We'll need peer scoring/banning disabled globally to prevent nodes impacted by faults from being permanently ejected from the network.

Lighthouse: --disable-peer-scoring

Lodestar: use flag disablePeerScoring

Teku: –Xp2p-gossip-scoring-enabled

Prysm: –disable-peer-score

Nimbus: –direct-peer (not entirely sure if it disables ALL peer scoring though)

https://discord.com/channels/595666850260713488/892088344438255616/1163511789946929202
@barnabasbusa
Copy link
Contributor

Would you want to be able to enable/disable this flag per participant or global switch only?

@barnabasbusa barnabasbusa mentioned this issue Oct 19, 2023
Merged
@barnabasbusa
Copy link
Contributor

correct flags:

Lighthouse: --disable-peer-scoring

Lodestar: --disablePeerScoring

Teku: --Xp2p-gossip-scoring-enabled

Prysm: --disable-peer-scorer

Github issue converts -- to – which leads to a nasty bug if you try to use the github version of –.

In the future please always format the text in ` `.

barnabasbusa added a commit that referenced this issue Oct 19, 2023
@barnabasbusa
feat: add "disable_peer_scoring" global flag (#311)
63f7ff3 
Closes: #304
@github-actions github-actions bot mentioned this issue Oct 19, 2023
Merged
@barnabasbusa
Copy link
Contributor

Heads up, prysm already disabled peer scoring if the peers are static peers.
And currently we use cmd.append("--peer=" + ctx.multiaddr) (https://github.com/kurtosis-tech/ethereum-package/blob/main/src/cl/prysm/prysm_launcher.star#L297) for all peers.

@barnabasbusa
Copy link
Contributor

Teku will also never disconnect from static peers.

h4ck3rk3y added a commit that referenced this issue Oct 25, 2023
@github-actions @h4ck3rk3y
chore(main): release 1.0.0 (#307)
ef2b1d7 
🤖 I have created a release *beep* *boop*
---


##
[1.0.0](0.6.1...1.0.0)
(2023-10-25)


### ⚠ BREAKING CHANGES

* merged genesis generation
([#288](#288))

### Features

* add "disable_peer_scoring" global flag
([#311](#311))
([63f7ff3](63f7ff3)),
closes
[#304](#304)
* add mock mev ci
([#310](#310))
([d4bec9e](d4bec9e))
* add trusted setup file to teku
([#325](#325))
([605e155](605e155))
* bump json-rpc-snooper
([#329](#329))
([242a4cd](242a4cd))
* json to yaml everything
([#332](#332))
([c9669ae](c9669ae))
* merged genesis generation
([#288](#288))
([743ba44](743ba44))
* rework how keys are generated
([#301](#301))
([59f15ca](59f15ca))
* **tooling:** Add Ethereum Metrics Exporter
([#331](#331))
([de5eee8](de5eee8))
* use base image instead of pip install
([#322](#322))
([18da90b](18da90b))


### Bug Fixes

* add readme for mev-builder-cl-image
([#314](#314))
([c46b6bf](c46b6bf))
* formatting - missing jwt secret
([#312](#312))
([728964c](728964c))
* genesis validators root had an extra new line
([#326](#326))
([4fa4937](4fa4937))
* geth flags for verkle genesis
([#328](#328))
([e721373](e721373))
* path based storage - disable for older forks
([#336](#336))
([76e3424](76e3424))
* path based storage disable for elecra
([#316](#316))
([86fa8ef](86fa8ef))
* remove image name for ethereum-metrics-exporter
([#335](#335))
([4bac042](4bac042))
* remove path based storage when builder is used
([#327](#327))
([d3cf3f4](d3cf3f4))
* revert the default deneb at epoch 4
([#323](#323))
([9342418](9342418))
* take out the genesis versions as constants
([#324](#324))
([a8afcef](a8afcef))
* wrong builder metrics flag
([#319](#319))
([51a4422](51a4422))
* zero count validators and parallel keystore generation
([#302](#302))
([18b141e](18b141e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gyanendra Mishra <anomaly.the@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bsamuels453 @barnabasbusa