Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken testnet-verifier #57

Closed
gbouv opened this issue Oct 25, 2022 · 2 comments
Closed

Remove broken testnet-verifier #57

gbouv opened this issue Oct 25, 2022 · 2 comments
Labels
eth2-merge-kurtosis-module This label tracks issues that came from the previous module

Comments

@gbouv
Copy link
Contributor

gbouv commented Oct 25, 2022

The testnet-verifier is currently broken for several reasons.

==
First, I run the module and almost immediately run:

./merge_testnet_verifier --ttd 0 --ttd-epoch-limit 0 --verif-epoch-limit 5 --client geth,http://<IP_GETH_NODE>:8545

and it runs the tests, even though we're not yet at epoch 5. I think it should wait for epoch 5 to be reached based on the description of verif-epoch-limit

==
Second, when I add a beacon node:

./merge_testnet_verifier --ttd 0 --ttd-epoch-limit 0 --verif-epoch-limit 5 --client geth,http://<IP_GETH_NODE>:8545 --client lighthouse,http://<IP_LIGHTHOUSE_BEACON>:4000

It loops forever with:

WARN[10-24|14:22:05] Error getting ttd block/slot             client=Lighthouse clientID=0 error="time before genesis"

When I manually kill it with Ctrl+C, before exiting it prints:

CRIT[10-24|14:50:40] Post-Merge Beacon Blocks Produced        client=Lighthouse clientID=0 pass=false extra="0 < 1"
CRIT[10-24|14:50:40] Post-Merge Justified Epochs              client=Lighthouse clientID=0 pass=false extra="0 < 1"
CRIT[10-24|14:50:40] Post-Merge Finalized Epochs              client=Lighthouse clientID=0 pass=false extra="0 < 2"
CRIT[10-24|14:50:40] Post-Merge Epoch Attestation Performance client=Lighthouse clientID=0 pass=false extra="0 < 85"
CRIT[10-24|14:50:40] Post-Merge Epoch Target Attestation Performance client=Lighthouse clientID=0 pass=false extra="0 < 85"
CRIT[10-24|14:50:40] Post-Merge Sync Participation Percentage client=Lighthouse clientID=0 pass=false extra="0 < 85"

All values are at zero.

==
Third, when I pass also a validator node:

./merge_testnet_verifier --ttd 0 --ttd-epoch-limit 0 --verif-epoch-limit 5 --client geth,http://<IP_GETH_NODE>:8545 --client lighthouse,http://<IP_LIGHTHOUSE_BEACON>:4000 --client lighthouse,http://<IP_LIGHTHOUSE_VALIDATOR>:5042

It immediately crashes complaining it can't reach the validator node.

==
Not entirely sure what's happening. Discussing with @parithosh on Discord, it could be that the verifier is confused because it's waiting for TTD to be reached, but here since we're running the network post merge from the start it's never really reached (and we set TTD to zero).
We should also check how the verifier is reading from the beacon and the validator, it seems it's having trouble retrieving the data.

@gbouv gbouv changed the title test-verifier is broken testnet-verifier is broken Oct 25, 2022
@gbouv
Copy link
Contributor Author

gbouv commented Oct 28, 2022

Posted it on the upstream repo: ethereum/merge-testnet-verifier#4

@mieubrisse
Copy link
Contributor

mieubrisse commented Nov 24, 2022

Verified with @parithosh and @marioevz that the best thing to do right now is to remove it: https://discord.com/channels/783719264308953108/969943161264812112/1045035000875200532

@mieubrisse mieubrisse changed the title testnet-verifier is broken Remove broken testnet-verifier Dec 14, 2022
@h4ck3rk3y h4ck3rk3y transferred this issue from kurtosis-tech/zzz-deprecated-eth2-merge-kurtosis-module Dec 19, 2022
@h4ck3rk3y h4ck3rk3y added the eth2-merge-kurtosis-module This label tracks issues that came from the previous module label Dec 19, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eth2-merge-kurtosis-module This label tracks issues that came from the previous module
Projects
None yet
Development

No branches or pull requests

3 participants